Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

createTicket respects alert/autorespond negatives #1435

Merged
merged 2 commits into from
Dec 24, 2014
Merged

createTicket respects alert/autorespond negatives #1435

merged 2 commits into from
Dec 24, 2014

Commits on Oct 27, 2014

  1. createTicket respects alert/autorespond negatives

    It was previously not possible to use the `alert` and `autorespond` flags in a negative way to prevent those two events, since the ternary operator would have used the `false` ternary value, which was `true`.  This corrects that by allowing the default of `true` to be used only when the `$data` array does not have the appropriate keys set.  Assigning `$data['source']` was altered to use the same formatting and caution against an undefined index error.
    stevepacker committed Oct 27, 2014
    Configuration menu
    Copy the full SHA
    979888d View commit details
    Browse the repository at this point in the history

Commits on Nov 19, 2014

  1. XML supports false alert/autorespond, using isset

    - Allows the string "false" to be used in the XML payload as the documentation demonstrates, and have that be interpreted as a boolean false.
    - Switching $alert/$autorespond to use isset(), and forcing those variables to be type-casted to booleans.
    stevepacker authored and Stephen Packer committed Nov 19, 2014
    Configuration menu
    Copy the full SHA
    5d0ddb6 View commit details
    Browse the repository at this point in the history