Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent internal activity alert #1865

Merged
merged 2 commits into from
Mar 30, 2015

Conversation

greezybacon
Copy link
Contributor

This adds the ability of the system to notify agents when another agent replies to a ticket. This is implemented by extending the "New Internal Note Alert" to also include replies by agents. The same alert settings will be applied to both alerts — new internal notes and new replies.

protich and others added 2 commits March 18, 2015 10:26
Add initial concept of activity alert/subscription model to ticket activity.
@@ -673,19 +673,20 @@ function alertAcctManagerONNewMessage() {
return ($this->get('message_alert_acct_manager'));
}

function alertONNewNote() {
//TODO: change note_alert to activity_alert
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should change note_alert_* to activity_alert_* to ward-off confusions going forward.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the db-migration label to signify renaming the config settings on some upgrade task

@Chefkeks
Copy link
Contributor

Another great enhancement coming down the road ;) 👍

@robintoy
Copy link

Looking forward to this as it keep all people in the loop without having to open each ticket.

@protich
Copy link
Member

protich commented Mar 30, 2015

I think we should consider adding a db patch to change note_alert_* to activity_alert_*

@greezybacon
Copy link
Contributor Author

@protich I was thinking the patch should go on one of the existing patches toward develop-next so that the db patches don't need to be rewritten

protich added a commit that referenced this pull request Mar 30, 2015
Agent internal activity alert

Reviewed-By: Peter Rotich <peter@osticket.com>
@protich protich merged commit 286e7c4 into osTicket:develop Mar 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants