Consistently handle emails #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whether HTML ticket thread is enabled or not, consistently handle the processing of the email bodies
| $body=Format::safe_html($body); //Balance html tags & neutralize unsafe tags. | ||
| if (!$cfg->isHtmlThreadEnabled()) | ||
| $body = convert_html_to_text($body); | ||
| if ($cfg->isHtmlThreadEnabled()) { |
There was a problem hiding this comment.
Probably need to add
if (!trim($body, " <>br/\t\n\r")) return "--";-- is used to signify to the front-end (when displayed to a user) that no message was given
Provide fallback html2text mechanism if PHP xml extension is not available
| @@ -27,6 +27,9 @@ | |||
| function convert_html_to_text($html, $width=74) { | |||
| $html = fix_newlines($html); | |||
|
|
|||
| if (!extension_loaded('xml')) | |||
| return strip_tags($html); | |||
There was a problem hiding this comment.
Consider changing <br>, </div> & </p> to new lines before stripping tags.
If the xml extension for php is not loaded, this patch will do a better job of honoring line break hints in the html.
protich
added a commit
that referenced
this pull request
Oct 22, 2013
Consistently handle emails Reviewed-By: Peter Rotich <peter@osticket.com>
JoshBeckerPLCH
pushed a commit
to plch/osTicket
that referenced
this pull request
Feb 28, 2020
…-object thread: getId On Non-Object
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whether HTML ticket thread is enabled or not, consistently handle the processing of the email bodies