iFrame #2940
Merged
iFrame #2940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return "</{$el}>"; | ||
|
|
||
| // Remove iframe and embed without src (perhaps striped by spec) | ||
| // It would be awesome to rickroll such entry :) |
|
I'm trying to open a ticket with bioinformatics on the Unicode corruption issue. Looks like I can't post on their forum even after confirming my email address... |
Encoded entities can be used to bypass safety checks Don't remove iframe when using xml_dom to balance tags
greezybacon
added a commit
that referenced
this pull request
Mar 17, 2016
iFrame Reviewed-By: Jared Hancock <jared@osticket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request addresses a case where iframe gets dropped as well was potential XSS security exploit in html cleanup.