Rewrites Mail_Parse::parsePriority function #491
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Best version of #348 static keyword added to enable strict test mode.
Allow tester to run single test by specifying it on command line: php run-tests.php TestMyThing etc. Still works for normal tests.
Creates a regression test for the parsePriority function, as suggested by GreezyBacon #348 (comment)
| $priority=3; | ||
| } | ||
| return $priority; | ||
| static function parsePriority($header=null){ |
There was a problem hiding this comment.
static keyword was added purely to pass the tests.. and as this function is only ever called statically, it makes sense too.
https://github.com/osTicket/osTicket-1.8/search?q=parsePriority&ref=cmdform
protich
added a commit
that referenced
this pull request
Jun 18, 2014
Rewrites Mail_Parse::parsePriority function Reviewed-By: Peter & Jared
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced previous pull request #348
Includes best function as tested/defined. 4526e54
Includes Test class as described by greezy #348 (comment) cb316f6
Tested repeatedly with old function (failed miserably), and new function, passed beautifully. Test designed to determine best function, modified to ensure function operates as intended, original test https://gist.github.com/clonemeagain/8066113
Future tests should therefore pass once entire pull request is merged. I'm liking the idea of adding tests!
Also, includes modification to test suite allowing individual test suite to run, instead of forcing ALL tests to run sequentially. Only useful for testing tests.. but still useful. 4822b86
Original issue: #343