Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File Storage API v2 #515

Merged

Conversation

greezybacon
Copy link
Contributor

This patches a few issues with the storage API realized when writing a plugin for Amazon S3. This makes a few adjustments to the storage API:

  • Add a flush() method, to inform the backend that no more write() calls will be invoked
  • Add getNativeHashAlgos() and getHashDigest() which allow the backend to advertise hashing algorithms supported remotely. getHashDigest() is used to fetch a hash in the migration process without reading the entire file contents again.
  • Download file name generation more consistent (handled in class HTTP)
  • Migration will honor the chunk size advertised by the target backend. For something like the database backend, it is useful if every call to the write() method contains a specific amount of data, if possible
  • As a bonus, the Http::redirect() may hang under some circumstances. This patch includes a fix to browser hang on redirect

protich added a commit that referenced this pull request Feb 4, 2014
File Storage API v2

Reviewed-By: Peter Rotich <peter@osticket.com>
@protich protich merged commit b595c23 into osTicket:develop-next Feb 4, 2014
@greezybacon greezybacon deleted the feature/file-storage-api-2 branch February 7, 2014 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants