Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assume ISO-8859-1 when charset is unknown or bogus #551

Merged
merged 1 commit into from
Feb 11, 2014

Conversation

protich
Copy link
Member

@protich protich commented Feb 10, 2014

Unfortunately, this is necessary because some mail clients send in content without defining the charset or at worse using a freaking wrong/invalid charsets like 'default'

Unfortunately, this is necessary because some mail clients send in content without defining
the charset or at worse using freaking wrong/invalid charsets like
'default'!
greezybacon added a commit that referenced this pull request Feb 11, 2014
Assume ISO-8859-1 when charset is unknown or bogus

Reviewed-By: Jared Hancock <jared@osticket.com>
@greezybacon greezybacon merged commit 1d6ea65 into osTicket:develop-next Feb 11, 2014
@molul
Copy link

molul commented Feb 27, 2014

I'm afraid this is still happening on 1.8.1. Emails on ISO-8859 get truncated.

@greezybacon
Copy link
Contributor

Can you post an example email

@molul
Copy link

molul commented Feb 27, 2014

Sure! Here is the email source and attached is how it gets posted in my osTicket installation:

MIME-Version: 1.0
Received: by 10.58.151.6 with HTTP; Thu, 27 Feb 2014 11:34:27 -0800 (PST)
Date: Thu, 27 Feb 2014 20:34:27 +0100
Delivered-To: luismorcillo@gmail.com
Message-ID: CAPUXZb7257DPQmZA25qudD93P7+j2=Xh2ePGW02vtdP6fKXxqw@mail.gmail.com
Subject: =?ISO-8859-1?Q?Ay=FAdame?=
From: Luis Morcillo luismorcillo@gmail.com
To: support18 support18@brainstorm.es
Content-Type: multipart/alternative; boundary=047d7bdc8c1acaccb204f368681a

--047d7bdc8c1acaccb204f368681a
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

This is an ISO-8859 coded test email.

The title has a spanish word with
accent, and due to that, the ticket subject will be renamed to "[No
subject]".

On the other side, the body will get truncated (not blank, just truncated)
if I post a word with tilde. Here it is: V=E1monos!

--=20
Luis Morcillo Luque

--047d7bdc8c1acaccb204f368681a
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

This is an ISO-8859 coded test email. The title has a= spanish word with accent, and due to that, the ticket subject will be rena= med to "[No subject]".

On the other = side, the body will get truncated (not blank, just truncated) if I post a w= ord with tilde. Here it is: V=E1monos!

--
Luis Morcillo Luque

--047d7bdc8c1acaccb204f368681a--

iso-8859_error

Thanks in advance! :)

@protich
Copy link
Member Author

protich commented Feb 28, 2014

@molul - If you don't mind please open a new issue and we'll work on tracking down the cause of the cutoff text.

@molul
Copy link

molul commented Feb 28, 2014

Sure! Here it is: #633

@ntozier ntozier mentioned this pull request Jan 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants