xss: FAQ Category On Errors #5517
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses 1/2 of the vulnerability reported at 5514 where pasting an XSS Payload in the Category Description/Notes and saving changes without filling out required info executes the XSS Payload. This is due to the system not sanitizing the return values on errors. This adds `Format::sanitize()` to the Description and Notes fields so that any value displayed is properly sanitized. The Description/Notes are properly sanitized before saving to the database, the issue only lies when returning values on errors.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses 1/2 of the vulnerability reported at #5514 where pasting an XSS Payload in the Category Description/Notes and saving changes without filling out required info executes the XSS Payload. This is due to the system not sanitizing the return values on errors. This adds
Format::sanitize()to the Description and Notes fields so that any value displayed is properly sanitized. The Description/Notes are properly sanitized before saving to the database, the issue only lies when returning values on errors.