issue: Edit Entry Dropped Attachments #5873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This addresses an issue where editing your own Thread Entry and clicking Save two separate times drops the attachment(s). This is due to the order of operations in the backend where if editing your own Thread Entry we delete the previous entry and set `$old` to the original Thread Entry (parent of the previous entry). This causes the attachment lookup to search for the wrong `object_id` which obviously finds no attachments. This moves the attachment lookup before we delete the previous entry so we can search with the appropriate ID.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses an issue where editing your own Thread Entry and clicking Save two separate times drops the attachment(s). This is due to the order of operations in the backend where if editing your own Thread Entry we delete the previous entry and set
$oldto the original Thread Entry (parent of the previous entry). This causes the attachment lookup to search for the wrongobject_idwhich obviously finds no attachments. This moves the attachment lookup before we delete the previous entry so we can search with the appropriate ID.