file: Fix saving backend char #595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the file type normally defaults to the system default (for fetched emails at least), the backend char was not saved, because the file type char was left at the system default. Therefore, if a file is saved to a backend other than the default (in the database), the data will likely be saved to the backend, but the file metadata will reflect the incorrect backend. The only reason the file type char was not defaulted in the AttachmentFile::save() method was for the migration process from osTicet 1.6 to osTicket 1.7. This is mitigated by passing `false` specifically from the migration task. Since otherwise the file type char is now set, the backend char is now saved with the file metadata.
protich
added a commit
that referenced
this pull request
Feb 26, 2014
file: Fix saving backend char Reviewed-By: Peter Rotich <peter@osticket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the file type normally defaults to the system default (for fetched emails at least), the backend char was not saved, because the file type char was left at the system default. Therefore, if a file is saved to a backend other than the default (in the database), the data will likely be saved to the backend, but the file metadata will reflect the incorrect backend.
The only reason the file type char was not defaulted in the
AttachmentFile::save()method was for the migration process from osTicet 1.6 to osTicket 1.7. This is mitigated by passingfalsespecifically from the migration task.Since otherwise the file type char is now set, the backend char is now saved with the file metadata.