Allow new ticket without required contact fields #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a staff member creates a new ticket and cancels the user-lookup / create-new-user dialog, and the contact information form has a required field other than the name and email address fields, the ticket cannot be created because the required fields for new clients are not shown and can therefore not have a required value. This patch allows new clients to be created without the required fields when the ticket is created by staff members.
| @@ -2045,7 +2052,7 @@ function create($vars, &$errors, $origin, $autorespond=true, $alertstaff=true) { | |||
| // account created or detected | |||
| if (!$user) { | |||
| $user_form = UserForm::getUserForm()->getForm($vars); | |||
| if (!$user_form->isValid($field_filter) | |||
| if (!$user_form->isValid($field_filter('user')) | |||
protich
added a commit
that referenced
this pull request
Mar 5, 2014
Allow new ticket without required contact fields Reviewed-By: Peter Rotich <peter@osticket.com>
|
HI. I've got osTicket 1.9.4. I try set email as an optional field. I create system to manage phone tickets and not always clients which an emails. Anyone knows how disable email validation in contact information? |
|
Well, I understand and support your use case; however, currently osTicket strictly requires the email field internally, and expects it to be an email address. If you proceed to change that, you're going to face a difficult road. We're hoping to broaden osTicket to use "channels" and support things other than email. This will remove the necessity of the email address. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a staff member creates a new ticket and cancels the user-lookup / create-new-user dialog, and the contact information form has a required field other than the name and email address fields, the ticket cannot be created because the required fields for new clients are not shown and can therefore not have a required value.
This patch allows new clients to be created without the required fields when the ticket is created by staff members.