Fix munging of linked external images #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 21, 2014 13:24
And use admin-defined site logo
htmLawed stripped/discarded <div> tags nested inside inline tags such as <a>. The previous replacement engine would replace <img> tags with <div> tags and would cause the HTML to be corrupted by htmLawed. This patch uses <span> tags which have CSS rules to be displayed as inline-blocks. This should stay truer to the normal sizing and placement of the original <img> tag.
Previously, the display of the button was incorrect and more than one button might have been displayed.
protich
added a commit
that referenced
this pull request
May 21, 2014
Fix munging of linked external images Reviewed-By: Peter Rotich <peter@osticket.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
htmLawed stripped/discarded
<div>tags nested inside inline tags such as<a>. The previous replacement engine would replace<img>tags with<div>tags and would cause the HTML to be corrupted by htmLawed.This patch uses
<span>tags which have CSS rules to be displayed as inline-blocks. This should stay truer to the normal sizing and placement of the original<img>tag.References:
http://osticket.com/forum/discussion/77309/osticket-1-9-poor-html-handling