Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no local Aalisa code execution for Java or Python #1709

Merged
merged 11 commits into from
Feb 25, 2019

Conversation

reteprelief
Copy link
Contributor

Fixes #1604

@ghost ghost assigned reteprelief Feb 22, 2019
@ghost ghost added the review label Feb 22, 2019
}
return null;
return ResultUtil.createErrorResult("Python script '" + scriptPath + "' execution not supported", null);
// try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete commented out code.

* Recursively consistency check that all leaf components have all features
* connected. Retruns Result object with issues detailing each unconnected feature.
*/
// public static AnalysisResult allComponentFeaturesConnected(ComponentInstance ci) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete commented out code.

@@ -128,7 +128,7 @@ public Method getJavaMethod(String javaMethod) {
return obj.getClass();
}

return getJavaClassFromProjects(className);
return null;// getJavaClassFromProjects(className);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please delete commented out code and now unused method getJavaClassFromProjects.

@ghost ghost assigned lwrage Feb 25, 2019
@lwrage lwrage merged commit 87e2a32 into develop Feb 25, 2019
@ghost ghost removed the review label Feb 25, 2019
@lwrage lwrage deleted the 1604_no_local_alisa_code branch February 25, 2019 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants