Allow creating classifier when setting subcomponent or feature classifier #1944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the ClassifierHandler
…ier_when_setting_classifier
…ier_when_setting_classifier
…ier_when_setting_classifier
…ier_when_setting_classifier
…ier_when_setting_classifier
1198_create_classifier_when_setting_classifier Conflicts: ge/org.osate.ge/src/org/osate/ge/internal/ui/properties/SetFeatureClassifierPropertySection.java ge/org.osate.ge/src/org/osate/ge/internal/ui/properties/SetSubcomponentClassifierPropertySection.java
|
The code uses Optional.isEmpty(). This doesn't exist in Java 8: org/osate/ge/internal/util/EditingUtil.java:[240] |
|
Fixed and I've updated my dev environment to ensure it's using JDK 8. |
RyanMcilnay
reviewed
Aug 14, 2019
|
@RyanMcilnay fixed issue that you raised and merged master into the branch. |
RyanMcilnay
approved these changes
Aug 14, 2019
| @@ -61,6 +63,18 @@ public AgeBusinessObjectSelection(final Collection<? extends BusinessObjectConte | |||
| modify(boc -> c.cast(boc.getBusinessObject()), (bo, boc) -> modifier.accept(bo)); | |||
| } | |||
|
|
|||
| @Override | |||
| public <T extends EObject, O> void modifyWithOperation(final OperationBuilder<O> opBuilder, Class<T> c, | |||
There was a problem hiding this comment.
Add final to parameters
philip-alldredge
deleted the
1198_create_classifier_when_setting_classifier
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1198 create classifier when setting classifier
Closes #1198