go.mod: remove exclude github.com/mattn/go-sqlite3
#693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This directive was added in commit 29f66a2 to workaround an issue with the github.com/containers/image/v5 v5.22 where some misconfiguration/misrelease of go-sqlite caused problems. This seems to be no longer necessary, I followed the reproducer steps from the original commit and see no errors (anymore). The reason this is useful is so that we run the gen-manifests command directly via `go run`. Right now it will error with: ``` $ go run github.com/osbuild/images/cmd/gen-manifests@latest go: github.com/osbuild/images/cmd/gen-manifests@latest (in github.com/osbuild/images@v0.61.0): The go.mod file for the module providing named packages contains one or more exclude directives. It must not contain directives that would cause it to be interpreted differently than if it were the main module. ``` (c.f. golang/go#40276). Removing the `exclude` shoudl fix that.
mvo5
added a commit
to mvo5/osbuild-composer
that referenced
this pull request
May 16, 2024
This is a result of the outcome of osbuild#4124 Achilleas suggested that instead of having a copy of `gen-manifests` in osbuild-composer we could use the one from images. AFAICT nothing in the code references `gen-manifests` except the `test/README` so it seems safe to remove and just run the one from images. Note that osbuild/images#693 needs to land before: ``` go run github.com/osbuild/images/cmd/gen-manifests@latest ``` works.
achilleas-k
approved these changes
May 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This directive was added in commit 29f66a2 to workaround an issue with the github.com/containers/image/v5 v5.22 where some misconfiguration/misrelease of go-sqlite caused problems.
This seems to be no longer necessary, I followed the reproducer steps from the original commit and see no errors (anymore).
The reason this is useful is so that we run the gen-manifests command directly via
go run. Right now it will error with:(c.f. golang/go#40276).
Removing the
excludeshoudl fix that.