Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: remove exclude github.com/mattn/go-sqlite3 #693

Merged
merged 1 commit into from
May 16, 2024

Commits on May 16, 2024

  1. go.mod: remove exclude github.com/mattn/go-sqlite3

    This directive was added in commit 29f66a2 to workaround an
    issue with the github.com/containers/image/v5 v5.22 where some
    misconfiguration/misrelease of go-sqlite caused problems.
    
    This seems to be no longer necessary, I followed the reproducer
    steps from the original commit and see no errors (anymore).
    
    The reason this is useful is so that we run the gen-manifests
    command directly via `go run`. Right now it will error with:
    ```
    $ go run github.com/osbuild/images/cmd/gen-manifests@latest
    go: github.com/osbuild/images/cmd/gen-manifests@latest (in github.com/osbuild/images@v0.61.0):
    	The go.mod file for the module providing named packages contains one or
    	more exclude directives. It must not contain directives that would cause
    	it to be interpreted differently than if it were the main module.
    ```
    (c.f. golang/go#40276).
    
    Removing the `exclude` shoudl fix that.
    mvo5 committed May 16, 2024
    Configuration menu
    Copy the full SHA
    23a154b View commit details
    Browse the repository at this point in the history