Tests: Add unit tests for org.osbuild.mkfs.xfs stage #1678
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
4f96959
to
e415dcc
Compare
elkoniu
changed the title
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
e415dcc
to
32b34cd
Compare
mvo5
reviewed
Mar 21, 2024
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
32b34cd
to
49bfeb7
Compare
|
@mvo5 thanks a lot for the review. I have fixed some obvious issues and rebased to latest main. |
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
49bfeb7
to
9af55d7
Compare
mvo5
reviewed
Mar 22, 2024
supakeen
previously approved these changes
Mar 27, 2024
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
3 times, most recently
from
a88e4a0
to
300a65a
Compare
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
300a65a
to
afddd46
Compare
|
Has an unused |
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
afddd46
to
ae148ae
Compare
mvo5
approved these changes
Apr 3, 2024
elkoniu
force-pushed
the
org.osbuild.mkfs.xfs-unit-tests
branch
from
ae148ae
to
c8956aa
Compare
|
Gitlab tests have been poked to retry. |
Weird. I see some failures in the history of the workflow that seem to be reformatting the devcontainer.json, but that wasn't touched. I can't imagine how a check this simple could be flaky. Unless there's some inconsistency or non-deterministic ordering in |
supakeen
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add stage unit test for mkfs.xfs