otk: detect circular imports #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvo5
commented
Jun 24, 2024
| @@ -65,7 +65,6 @@ def resolve_dict(ctx: Context, state: State, tree: dict[str, Any]) -> Any: | |||
| if isinstance(val, str): | |||
| val = substitute_vars(ctx, val) | |||
| if is_directive(key): | |||
|
|
|||
There was a problem hiding this comment.
This was added by precommit :( (which I still do not like very much!)
supakeen
reviewed
Jun 24, 2024
Now that we have state during the recursion we can detect circular imports. This commit adds it and a matching test.
supakeen
approved these changes
Jun 24, 2024
achilleas-k
reviewed
Jun 24, 2024
Comment on lines
+22
to
+23
| if includes is None: | ||
| includes = self.includes.copy() |
There was a problem hiding this comment.
Late to the party but:
Should we make copy() "smarter" and add something like:
if path != includes[-1]:
includes.append(path)so that whenever the path changes it's automatically added to the include stack?
Too smart?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now that we have state during the recursion we can detect circular imports. This commit adds it and a matching test.