Better tab completion in GAP for members of Julia "record" #722
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This restores tab completion after `Julia.`, by overwriting ("monkey
patching") the relevant GAP function. This is only safe because we use a fixed
GAP version; of course if we update GAP, we must update this patch. But once
gap-system/gap#4667 is merged and a newer snapshot of
GAP is used by GAP.jl, we can get rid of this hack again.
fingolfin
force-pushed
the
mh/tab-complation
branch
from
37029d1
to
eef2c25
Compare
Codecov Report
@@ Coverage Diff @@
## master #722 +/- ##
==========================================
- Coverage 82.24% 79.38% -2.86%
==========================================
Files 44 45 +1
Lines 3570 3702 +132
==========================================
+ Hits 2936 2939 +3
- Misses 634 763 +129
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This restores tab completion after
Julia., by overwriting ("monkeypatching") the relevant GAP function. This is only safe because we use a fixed
GAP version; of course if we update GAP, we must update this patch. Better of
course is to get this patch included in GAP. This is in progress, but
improvements to the patch were requested there, which while sensible, will
take some time to address. In the meantime, for users of the GAP mode in
GAP.jl, this patch is a strict improvement.