Skip to content

Commit

Permalink
deduce finiteness of the normal subgroup in quo (#2842)
Browse files Browse the repository at this point in the history
if finiteness of the whole group was set in the computation on the GAP side
(suggested by Wolfram)
  • Loading branch information
ThomasBreuer authored and fieker committed Sep 29, 2023
1 parent 83f0fb7 commit 09ad5c0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
4 changes: 4 additions & 0 deletions src/Groups/sub.jl
Original file line number Diff line number Diff line change
Expand Up @@ -483,6 +483,10 @@ PermGroup
"""
function quo(G::T, N::T) where T <: GAPGroup
mp = GAP.Globals.NaturalHomomorphismByNormalSubgroup(G.X, N.X)::GapObj
# The call may have found out new information about `G.X`,
# for example that `G.X` is finite.
#FIXME: The GAP function should deal with this situation.
GAP.Globals.UseSubsetRelation(G.X, N.X)
cod = GAP.Globals.ImagesSource(mp)::GapObj
S = elem_type(G)
S1 = _get_type(cod)
Expand Down
11 changes: 11 additions & 0 deletions test/Groups/quotients.jl
Original file line number Diff line number Diff line change
Expand Up @@ -117,3 +117,14 @@ end
@test f(S([1,2,4,3]))==G[1]
@test f(S([2,1,4,3]))==one(G)
end

@testset "matrix groups" begin
K, a = CyclotomicField(3, "a");
S = matrix(K, [0 0 1; 1 0 0; 0 1 0])
T = matrix(K, [1 0 0; 0 a 0; 0 0 -a-1])
H3 = matrix_group(S, T)
C, iC = center(H3);
@test !has_is_finite(C)
Q, pQ = quo(H3, C);
@test has_is_finite(C)
end

0 comments on commit 09ad5c0

Please sign in to comment.