Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deduce finiteness of the normal subgroup in quo #2842

Merged
merged 1 commit into from Sep 25, 2023
Merged

deduce finiteness of the normal subgroup in quo #2842

merged 1 commit into from Sep 25, 2023

Conversation

ThomasBreuer
Copy link
Member

if finiteness of the whole group was set in the computation on the GAP side
(suggested by @wdecker)

if finiteness of the whole group was set in the computation on the GAP side
(suggested by Wolfram)
@ThomasBreuer
Copy link
Member Author

ThomasBreuer commented Sep 22, 2023

How shall I deal with the segmentation fault in doctest (1.9, macOS-latest)?
(And why are two tests running 20 hours after I had opened the pull request?)

@@ -483,6 +483,10 @@ PermGroup
"""
function quo(G::T, N::T) where T <: GAPGroup
mp = GAP.Globals.NaturalHomomorphismByNormalSubgroup(G.X, N.X)::GapObj
# The call may have found out new information about `G.X`,
# for example that `G.X` is finite.
#FIXME: The GAP function should deal with this situation.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What GAP function should deal with what situation? You mean, if anything is learned about a group $G$ then all its "known" subgroups and quotients should be informed about it? This is something the Homalg packages implement for their objects, it is kind of like immediate methods on steroids (with all the pros and cons this implies).

Or maybe just that all "related groups" that are known "and at hand / reachable / already handled in our code" ? As in the case of NaturalHomomorphismByNormalSubgroup, but potentially others (e.g. Normalizer)?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for not being precise enough.
I meant that GAP.Globals.NaturalHomomorphismByNormalSubgroup (or rather GAP.Globals.NaturalHomomorphismByNormalSubgroupNC) is a better place for the call of UseSubsetRelation, and I meant only one call for the pair (G, N).

@fingolfin fingolfin merged commit 7bd0160 into oscar-system:master Sep 25, 2023
9 of 12 checks passed
fieker pushed a commit that referenced this pull request Sep 29, 2023
if finiteness of the whole group was set in the computation on the GAP side
(suggested by Wolfram)
@ThomasBreuer ThomasBreuer deleted the TB_subset_relation branch October 10, 2023 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants