Introduce tropical geometry #1152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No, these are changes/commits that are already merged in the master branch I believe. |
thofma
reviewed
Mar 9, 2022
Ah, ok, so this one needs some rebasing onto master too. Thanks. |
lkastner
force-pushed
the
lk/noPadicSolver
branch
from
f9f72a2
to
045ab0c
Compare
lkastner
force-pushed
the
lk/noPadicSolver
branch
9 times, most recently
from
08b87a9
to
236e95b
Compare
fingolfin
reviewed
Mar 10, 2022
lkastner
force-pushed
the
lk/noPadicSolver
branch
5 times, most recently
from
97dd9f0
to
7ece4c3
Compare
fingolfin
previously requested changes
Mar 11, 2022
|
On Fri, Mar 11, 2022 at 12:42:43AM -0800, Tommy Hofmann wrote:
@thofma commented on this pull request.
> +function gcd(F::Vector{fmpq_poly})
+ F_gcd,F_latter = Iterators.peel(F)
+
+ for f in F_latter
+ F_gcd = gcd(F_gcd,f)
+ end
+
+ return F_gcd
+end
I am not a big fan of these ad hoc definitions here.
... and its inefficient ...
I'd use reduce(gcd, F) instead. Not any better wrt efficiency, but works
now
…
--
Reply to this email directly or view it on GitHub:
#1152 (comment)
You are receiving this because you are subscribed to this thread.
Message ID: ***@***.***>
|
lkastner
force-pushed
the
lk/noPadicSolver
branch
from
0415b56
to
4f530c1
Compare
YueRen
added a commit
that referenced
this pull request
Mar 16, 2022
…on Tommy's suggestion #1152 (review) Co-authored-by: Tommy Hofmann <thofma@gmail.com>
|
On Wed, Mar 16, 2022 at 05:40:59AM -0700, YueRen wrote:
@YueRen commented on this pull request.
> +
+
+###
+# 2. Basic constructors
+# ---------------------
+###
+
***@***.*** Markdown.doc"""
+ TropicalLinearSpace()
+
+Construct a tropical linear space from a degree 1 polynomial ideal
+
+# Examples
+"""
+function TropicalLinearSpace(ideal::MPolyIdeal{fmpq_poly})
+ return #...
Good suggestion, should definitely be done. Even if they will be filled in soon, I don't think incomplete functions should be merged into the main branch unless they throw an error when called.
tropical_linear_space?
or is this a type?
… --
Reply to this email directly or view it on GitHub:
#1152 (comment)
You are receiving this because you commented.
Message ID: ***@***.***>
|
lkastner
pushed a commit
that referenced
this pull request
Mar 16, 2022
…on Tommy's suggestion #1152 (review) Co-authored-by: Tommy Hofmann <thofma@gmail.com>
… + added short documentation
…e homogeneous to avoid crash if they are not
…ebra.Generic.MPoly to MPolyElem
…gebra.Generic.MPoly to MPolyElem
lkastner
force-pushed
the
lk/noPadicSolver
branch
from
5d8287a
to
2706931
Compare
lkastner
force-pushed
the
lk/noPadicSolver
branch
from
2706931
to
3ed3075
Compare
Co-authored-by: Max Horn <max@quendi.de>
lkastner
dismissed
fingolfin’s stale review
We adressed most of the issues and Max is currently busy otherwise.
|
You don't need the solver... Yue has a replacement within Oscar for it ..
…On Wed, 9 Mar 2022, 11:03 Lars Kastner, ***@***.***> wrote:
This is a subset of the big tropical geometry branch which contains the
basic architecture, but does not need the pAdicSolver. So this can be
merged and then some other branches will be rebased onto this.
------------------------------
You can view, comment on, or merge this pull request online at:
#1152
Commit Summary
- 74bc4fd
<74bc4fd>
More fixes to satisfy the incoming MapFromFunc changes
- e521ff5
<e521ff5>
PolyhedralGeometry: Access to basic properties of PolyhedralComplex
- 87b9c4f
<87b9c4f>
PolyhedralGeometry: Add some more basic functionality for PolyhedralComplex
- 4bf592e
<4bf592e>
TropicalGeometry: initial commit
- 229bdf4
<229bdf4>
TropicalGeometry: Make TropicalHypersurface(poly) work
- a66cdf2
<a66cdf2>
TropicalGeometry: Homogenize inhomogeneous input for polymake
- f860efc
<f860efc>
TropicalGeomtry: Ask for vertices of tropical hypersurface
- 81be961
<81be961>
chg: moving files around, adding basic properties for tropical varieties
- 77d6116
<77d6116>
fix: some broken properties
- c9fcbf4
<c9fcbf4>
fix: broken property
- 2687e87
<2687e87>
TropicalGeometry: Also homogenize homogeneous polynomials, i.e. add variable
- 2958f20
<2958f20>
fix: tropical numbers
- 0d35642
<0d35642>
TropicalGeometry: Remove brainstorming leftovers
- 17d8589
<17d8589>
TropicalGeometry: Nicer show methods
- bdbacd0
<bdbacd0>
TropicalGeometry: intersect tropical varieties
- 22887a1
<22887a1>
TropicalGeometry: Add documentation to intersect function
- 07fa000
<07fa000>
TropicalGeometry: Add stably_intersect
- 5105d9b
<5105d9b>
TropicalGeometry: Fix docstring for new Base.show
- 5c063a5
<5c063a5>
TropicalGeometry: Eliminate most warnings from duplicate definitions
- 263ed8b
<263ed8b>
chg (broken): restructured codebase
- 4aa2595
<4aa2595>
TropicalGeometry: Add constructor according to Note in AbstractAlgebra.jl
- be3ceab
<be3ceab>
TropicalGeometry: Start documentation
- 54ec8ca
<54ec8ca>
chg (broken): constructors for tropical hypersurfaces
- 74adf4d
<74adf4d>
fix: hypersurface from algebraic polynomial
- ca5c3f8
<ca5c3f8>
TropicalGeometry: Extract underlying poyhedral complex
- 1cf2edc
<1cf2edc>
fix: tropical_polynomial coefficients depend on min-max convention
- 13d515d
<13d515d>
chg: adding more documentation
- 6477fa2
<6477fa2>
chg: initial changes to base everything on PolyhedralComplex
- 5c9ec95
<5c9ec95>
fix: various bugs
- 93a665e
<93a665e>
TropicalGeometry: initial commit for valuation.jl
- 8f46ba0
<8f46ba0>
TropicalGeometry: fixing initial forms to work with ValuationMap
- 67c39ba
<67c39ba>
TropicalGeometry: support for trivial valuations
- fabacec
<fabacec>
TropicalGeometry: initial commit for initial.jl
- 07bdad6
<07bdad6>
TropicalGeometry: initial commit for groebner_basis.jl
- f80bc07
<f80bc07>
TropicalGeometry: initial (broken) version for tropical groebner bases
- 15dcc76
<15dcc76>
TropicalGeometry: fixing tropical groebner bases
- bb6cae2
<bb6cae2>
TropicalGeometry: fix groebner_basis header
- 078d2f5
<078d2f5>
TropicalGeometry: sanatizing input and names in groebner_bases.jl
- c350492
<c350492>
TropicalGeometry: adding complete_reduction parameter to groebner basis
- 12e2e05
<12e2e05>
TropicalGeometry: using MPolyBuildCtx in pseudo_change_base_ring
- b151b02
<b151b02>
TropicalGeometry: desimulate_valuation
- baf517a
<baf517a>
TropicalGeometry: code cleanup
- 2f46346
<2f46346>
TropicalGeometry: added return_lead parameter to groebner_basis
- 516a5f2
<516a5f2>
TropicalGeometry: initial commit groebner_polyhedron.jl
- 1b0de97
<1b0de97>
TropicalGeometry: new homogeneity_space
- 7ffe037
<7ffe037>
TropicalGeometry: code cleanup using Iterators.peel
- f49e4cb
<f49e4cb>
TropicalGeometry: initial commit for points.jl, added
random_linear_polynomials
- 161fc48
<161fc48>
TropicalGeometry: broken commit so we can continue working on Avi's desktop
- 62cbd1d
<62cbd1d>
TropicalGeometry: fixing random_linear_polynomials to return non-homogeous
polynomials
- a121f69
<a121f69>
TropicalGeometry: renamed random_linear_polynomial to
random_affine_linear_polynomial
- 7e5b9b3
<7e5b9b3>
TropicalGeometry: first version of tropical_link
- 6ba3d43
<6ba3d43>
TropicalGeometry: fixed tropical_link to ignore multiplicities
- 99c84f7
<99c84f7>
TropicalGeometry: typos and redundant Oscar.
- 835beff
<835beff>
TropicalGeometry: fixed check_weight_vector_for_legality
- 18d36f5
<18d36f5>
TropicalGeometry: code cleanup
- c716a39
<c716a39>
TropicalGeometry: added desimulate_valuation for weight vectors
- a974ad3
<a974ad3>
TropicalGeometry: fixing valuations + initial for ideals
- 8a91613
<8a91613>
TropicalGeometry: major ValuationMap overhaul
- 65b2e67
<65b2e67>
TropicalGeometry: added docu for groebner_basis
- 3eda357
<3eda357>
TropicalGeometry: added weight for trop hypersurfaces
- 04b7277
<04b7277>
TropicalGeometry: added desimulate_valuation for pairs of vectors
- 4837c67
<4837c67>
TropicalGeometry: fixed computing tropical reduced GB
- 0ead060
<0ead060>
TropicalGeometry: fixed tighten_simulation to create distinct x-monomials
- 210ae3d
<210ae3d>
TropicalGeometry: added show functions for ValuationMap
- a1a2ef2
<a1a2ef2>
TropicalGeometry: tighten_simulation fixed to divide by gcd of coefficients
- 81cf125
<81cf125>
TropicalGeometry: simulate_valuation restructured to allow for vectors of
polys as input
- af5d7bf
<af5d7bf>
TropicalGeometry: is_valuation_*, making tests more flexible
- 99ffd51
<99ffd51>
TropicalGeometry: tighten_valuation, improved docu
- 085bb7b
<085bb7b>
TropicalGeometry: t_adic_valuation, extended to more input types
- 82a255a
<82a255a>
TropicalGeometry: TropicalHypersurface, default to min and allow passing
valuation as argument
- dfbbb1b
<dfbbb1b>
TropicalGeometry: renamed tropical_numbers to tropical_semiring
- a0a0aee
<a0a0aee>
TropicalGeometry: initial restructured to allow polys, vectors and ideals
as input
File Changes
(22 files <https://github.com/oscar-system/Oscar.jl/pull/1152/files>)
- *M* docs/doc.main
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-25080aaf5efd96a8fd7f585fcee40bc1437001ada394d070e716ecc10786a55b>
(3)
- *M* docs/oscar_references.bib
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-073962c13ac44fe9a0b503c792b850ea09c2065492151fb16e364867c29dc4cc>
(13)
- *A* docs/src/TropicalGeometry/intro.md
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-b044e7489afc7c5e204a5ffc28ebf1bbc370d6b64e547bb3639e9bb7f21e4d88>
(29)
- *M* experimental/GModule/Cohomology.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-79f3f094f8fabbd9f1dac92c0eac7be2f5a9505a5f48a79cb519943dc5310dff>
(2)
- *M* experimental/GModule/GModule.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-d52f8a20b9ef93c33fc9a5eab5d5d675c849c624cac618ec9323f2900c048059>
(3)
- *M* src/Modules/ModuleTypes.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-c5b66874d96827632399fa60ef2e97345d7e9851ed184c6ecb338fe6c26be0ba>
(6)
- *M* src/Oscar.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-2b0f42aa9812c1d3a0e1613df08cd89260655b4016bd4bebad32e3037bf1e2be>
(1)
- *A* src/TropicalGeometry/curve.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-039892c0054c6d12760526ef4f950c422410d31987dbd9c6ebc36b1ee3955b37>
(67)
- *A* src/TropicalGeometry/groebner_basis.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-b391016fc4d30d27bde3ee2a0334e8a0d281aecb6366a240d0aec5cbdbbb8100>
(171)
- *A* src/TropicalGeometry/groebner_polyhedron.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-846e1ff604d27d15ce7ce884839ce9ed60997903a1c5d3c8a680305b4dedc5c0>
(48)
- *A* src/TropicalGeometry/hypersurface.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-d12016368b54900c809d98ff9633a4db3cbd47e66cf54b548aa1d2051cb4d1a6>
(256)
- *A* src/TropicalGeometry/initial.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-e89c52fb72b9478893aabb99f0b7c857f91607efabc0e07be2f10ce0137540d3>
(194)
- *A* src/TropicalGeometry/linear_space.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-b089bb67cb183bde5e1a8c843bee1ab63b2fddd850f38aeb26f94951d2f280b9>
(60)
- *A* src/TropicalGeometry/links.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-3b8a1c06a8c81526339121eea4af0cf365c72a8abd904c5cd05f840d3752089a>
(172)
- *A* src/TropicalGeometry/main.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-5daae5fb6ce745fcdf9067da9a19945f89f7c6390e9900d6fa4e2aab02994b10>
(80)
- *A* src/TropicalGeometry/numbers.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-a78125a04706720bb3becd835c7c46016c27899c783ed52badd7d6eb92fdc28c>
(449)
- *A* src/TropicalGeometry/points.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-f544a33c42eef58cf9a2719c343c22d1dafe71ddb6a5c512680a64f9b966b433>
(77)
- *A* src/TropicalGeometry/poly.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-61b152f79195a0db54245c30b2deec6ec14a3cef831caac84701db580a27c3ce>
(55)
- *A* src/TropicalGeometry/semiring.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-a6b6c221482d03057ce09f1d0eb458e6c386065671c29bb083aef639d12f92bc>
(504)
- *A* src/TropicalGeometry/valuation.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-c9638203ced3d0a956212cfc0d9438bad23b7ba587c85161c47a0fb12878159e>
(442)
- *A* src/TropicalGeometry/variety.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-0379b0f2b166f68b219d831526ab1e7c3e0894abb0f5db4c14b1cadb509e0ed1>
(93)
- *A* src/TropicalGeometry/variety_supertype.jl
<https://github.com/oscar-system/Oscar.jl/pull/1152/files#diff-19ad7969d831969c44e0286d2ca9a718ae16170630d0fc2a4b6729753186eb37>
(590)
Patch Links:
- https://github.com/oscar-system/Oscar.jl/pull/1152.patch
- https://github.com/oscar-system/Oscar.jl/pull/1152.diff
—
Reply to this email directly, view it on GitHub
<#1152>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA36CVYPS7PKN4S5GDSSSYTU7BZO3ANCNFSM5QJBGAQQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a subset of the big tropical geometry branch which contains the basic architecture, but does not need the
pAdicSolver. So this can be merged and then some other branches will be rebased onto this.