Minor improvements to tropical geometry code. #1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ncomplete function
fingolfin
reviewed
Apr 1, 2022
YueRen
approved these changes
Apr 1, 2022
|
This is still marked as a draft. If you think this is ready for merging, please use the "Ready for review" button. |
|
What's the status of this PR? |
|
Ahhh.... that merge was maybe not the best idea: the tests for it run last on 2nd of April. There is a good chance that in between, something changed which broke the test. In that case, we'll have to revert this merge... But let's hope that it's all fine :-). Next time, I recommend to first re-run the tests if they last run so long ago |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deal with the fallout of #1194.