admit result GrpAbFinGen for maximal_abelian_quotient
#1256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We will have the idea to cache the results of `maximal_abelian_quotient`, parametrized by their types. Then the question arises how to deal with the unary version, where up to now the result of the GAP function determines the type of the result in Oscar. One natural solution would be to take any cached result if there is one, which would make the description of the result type even more complicated.
|
I don't understand "We will have the idea to cache the results [...]" |
|
The current pull request does not yet deal with caching. Providing caching is straightforward for the version with prescribed type. |
fingolfin
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We will have the idea to cache the results of
maximal_abelian_quotient, parametrized by their types.Then the question arises how to deal with the unary version, where up to now the result of the GAP function determines the type of the result in Oscar.
One natural solution would be to take any cached result if there is one, which would make the description of the result type even more complicated.