rearrange/extend G-set related code #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moved `ismaximal`, `isconjugate_subgroup`, `maximal_subgroup_reps`, `low_index_subgroups`, `short_right_transversal`, `subgroup_reps`, `right_coset_action` from `experimental/GaloisGrp/Group.jl` to `src/Groups/GAPGroups.jl` - extended `action_homomorphism` in `src/Groups/gsets.jl` to cover the situation of `action_homomorphism` in `experimental/GaloisGrp/Group.jl` - added documentation for G-sets related functions - changed `blocks` and `maximal_blocks` to return G-sets not lists - moved the call of `__init_JuliaData` to Oscar's `__init__`
- added documentation for `permutation` - added iteration for G-sets, use `collect` instead of `elements` - renamed - `hall_subgroups_representatives` to `hall_subgroup_reps`, - `low_index_subgroups` (new function) to `low_index_subgroup_reps`, - `representatives_minimal_blocks` to `minimal_block_reps` - fixed the syntax of some jldoctests (there were no warnings ...) - removed the comment on GAP's `AllBlocks`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
moved
ismaximal,isconjugate_subgroup,maximal_subgroup_reps,low_index_subgroups,short_right_transversal,subgroup_reps,right_coset_actionfrom
experimental/GaloisGrp/Group.jltosrc/Groups/GAPGroups.jlextended
action_homomorphisminsrc/Groups/gsets.jlto cover thesituation of
action_homomorphisminexperimental/GaloisGrp/Group.jladded documentation for G-sets related functions
changed
blocksandmaximal_blocksto return G-sets not listsmoved the call of
__init_JuliaDatato Oscar's__init__TODO: