Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rearrange/extend G-set related code #1300

Merged
merged 2 commits into from
May 5, 2022
Merged

rearrange/extend G-set related code #1300

merged 2 commits into from
May 5, 2022

Commits on May 5, 2022

  1. rearrange/extend G-set related code 

    - moved `ismaximal`, `isconjugate_subgroup`, `maximal_subgroup_reps`,
  `low_index_subgroups`, `short_right_transversal`, `subgroup_reps`,
  `right_coset_action`
  from `experimental/GaloisGrp/Group.jl` to
  `src/Groups/GAPGroups.jl`

- extended `action_homomorphism` in `src/Groups/gsets.jl` to cover the
  situation of `action_homomorphism` in `experimental/GaloisGrp/Group.jl`

- added documentation for G-sets related functions

- changed `blocks` and `maximal_blocks` to return G-sets not lists

- moved the call of `__init_JuliaData` to Oscar's `__init__`
    @ThomasBreuer
    ThomasBreuer committed May 5, 2022
    Configuration menu
    Copy the full SHA
    c1c8e95 View commit details
    Browse the repository at this point in the history

  2. next iteration 

    - added documentation for `permutation`
- added iteration for G-sets, use `collect` instead of `elements`
- renamed
  - `hall_subgroups_representatives` to `hall_subgroup_reps`,
  - `low_index_subgroups` (new function) to `low_index_subgroup_reps`,
  - `representatives_minimal_blocks` to `minimal_block_reps`
- fixed the syntax of some jldoctests (there were no warnings ...)
- removed the comment on GAP's `AllBlocks`
    @ThomasBreuer
    ThomasBreuer committed May 5, 2022
    Configuration menu
    Copy the full SHA
    bb99823 View commit details
    Browse the repository at this point in the history