improvements/fixes for iso_oscar_gap
#1365
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modulus
instead ofdefining_polynomial
for field extensions(The former is documented, the latter not;
the former works for
FqDefaultFiniteField
, the latter not.)Still I would prefer the name
defining_polynomial
.)Vector{Any}
toVector{GAP.Obj}
(The former tries to convert entries from GAP to Julia, which may fail.)
iso_oscar_gap
for multivariate polynomial ringsiso_oscar_gap
for polynomial rings@attributes
calls that are no longer necessary