automorphisms of QabField() #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
implementation of automorphisms defined by \zeta_n \mapsto \zeta_n^k; for example, `QabAutomorphism(-1)` is complex conjugation. (Creating the coefficients list and then the field element is better than doing arithmetics with field elements or polynomials. It should be even cheaper to create the element in the cyclotomic field `F` directly via `F(coeffs)` instead of having an intermediate step `R(coeffs)` where `R` is the underlying polynomial ring, but this seems to be not allowed.)
Codecov Report
@@ Coverage Diff @@
## master #147 +/- ##
=======================================
Coverage 33.14% 33.14%
=======================================
Files 20 20
Lines 2993 2993
=======================================
Hits 992 992
Misses 2001 2001 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementation of automorphisms defined by \zeta_n \mapsto \zeta_n^k;
for example,
QabAutomorphism(-1)is complex conjugation.(Creating the coefficients list and then the field element
is better than doing arithmetics with field elements or polynomials.
It should be even cheaper to create the element in the cyclotomic field
Fdirectly via
F(coeffs)instead of having an intermediate stepR(coeffs)where
Ris the underlying polynomial ring, but this seems to be not allowed.)