make the Rubik's cube example run in Oscar #1711
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added `length` for elements of free groups - added `complement_class_reps` for groups - added `is_elementary_abelian` - fixed a bug in the construction of blocks homomorphisms (act with `on_sets`) - fixed `restrict_homomorphism` for action homomorphisms: When GAP gets a map that is controlled by Oscar data then it must create a map that is also controlled by Oscar data. (We install a special GAP method for `GAP.Globals.RestrictedMapping`. Extending `restrict_homomorphism` would have been simpler, but would not have covered all situations where GAP deals with the maps that rely on Oscar data.)
fingolfin
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lengthfor elements of free groupscomplement_class_repsfor groupsis_elementary_abelianon_sets)restrict_homomorphismfor action homomorphisms: When GAP gets a map that is controlled by Oscar data then it must create a map that is also controlled by Oscar data. (We install a special GAP method forGAP.Globals.RestrictedMapping. Extendingrestrict_homomorphismwould have been simpler, but would not have covered all situations where GAP deals with the maps that rely on Oscar data.)