-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Interface for blowups and blowdown morphisms #2780
Interface for blowups and blowdown morphisms #2780
Conversation
@HereAround : I would like to introduce a new type for toric blowups via fan subdivision. Up to now, the |
This looks good to me. Do you expect weighted blow ups to comply with these interface settings as well sometime in the farther future, when they are implemented? |
My understanding of weighted blowups does not go very deep as for now. But yes: I hope that they will also fit in here. The natural next step, however, would be sequences of simple blowups as they occur in a resolution process. That would be my first question here: Do you think this can accommodate a resolution of singularities? |
Basically yes, the sequence of blow-ups in a Hironaka-style resolution is just a means to construct the proper birational covered-scheme morphism which is the resolution of singularities. Only the command Let us now think about a Lipman-style resolution of surfaces: Here we have two different kinds of birational morphisms, namely blowups and normalization. Then we would need a more general type of proper birational morphism of schemes. In this case, it does not make sense to talk about exceptional divisors or exceptional loci either. so I would say that we ignore the case for now. If we think about a weighted/log-weighted resolution, the design fits again, but the morphisms will not be morphisms of schemes, but of stacks. |
c42939a
to
d4a8dc7
Compare
50dc6c3
to
ec46276
Compare
To keep working on this and after talking to @HechtiDerLachs, I have just squashed the previous commits and rebased this on the current master. |
ec46276
to
e5a2470
Compare
0f6834f
to
98fdb00
Compare
Another attempt on the rebase and squash... hopefully it works this time. |
Pushed a bit of clean-up, but more to come... |
The failing tests in |
I will look into this once I am back next week. But this definitely needs more cleanup as we discussed (documentation, missing functions to be added etc.) |
Unless somebody beats me to it, that is. |
659afa8
to
49265ed
Compare
f95b517
to
fda89cd
Compare
As per usual, the tests may show something unexpected. That put aside, I have completed the improvements that I wanted to complete. Those changes include:
Our current implementation of ideal sheaves only works for smooth toric varieties. (Reason: No time yet to look beyond it.) The previous implementation attempted to set the center of the blowup, and this failed for non-smooth examples appearing in the FTheoryTools. Since I cannot implement ideal sheaves for non-smooth toric varieties right now, I have altered this such that the blowdown morphism can be computed, but its attributes Other than this... should be good to go once the tests go green. Thank you for setting up the prototype @HechtiDerLachs ! |
fda89cd
to
e0152dc
Compare
e0152dc
to
f8af253
Compare
Based on conversation with @HechtiDerLachs, this seems ready for review. |
Since I hear no objections (yet) and this PR concerns experimental code, I will merge now. Thank you @HechtiDerLachs ! |
This is a draft to fix an interface for blowups in general. Please let me know your thoughts, ideas, and objections here.
CC: @afkafkafk13 , @HereAround @apturner .
As this is derived from #2779 , you only need to consider the last commit.