Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure toric varieties with a view towards toric blowups to come. #2795

Closed

Conversation

HechtiDerLachs
Copy link
Collaborator

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #2795 (165bfac) into master (3df9a13) will increase coverage by 0.05%.
The diff coverage is 56.66%.

@@            Coverage Diff             @@
##           master    #2795      +/-   ##
==========================================
+ Coverage   73.54%   73.59%   +0.05%     
==========================================
  Files         455      456       +1     
  Lines       64445    64445              
==========================================
+ Hits        47396    47429      +33     
+ Misses      17049    17016      -33     
Files Changed Coverage
src/AlgebraicGeometry/ToricVarieties/JToric.jl ø
...ies/NormalToricVarieties/standard_constructions.jl ø
...aicGeometry/ToricVarieties/Blowups/constructors.jl 56.66%

@fingolfin
Copy link
Member

According to @HereAround it would be nice if first PR #2780 gets ready and merged and then this one here, so I am not expecting changes here for now...

Next week @HereAround and @HechtiDerLachs and maybe others will discuss this and come up with a plan on how to proceed.

@HereAround
Copy link
Member

HereAround commented Oct 9, 2023

I believe I addressed this and more in my changes to #2780. Unless you object @HechtiDerLachs , I will close this PR.

@fingolfin fingolfin closed this Oct 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants