Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust printing of Galois context objects #2865

Merged

Conversation

fingolfin
Copy link
Member

  • ensure 'Galois' is always uppercase
  • ... but 'context' should be lowercase
  • adjust some doctest filters that did not match anymore
    (they matched for "Group" where now we had "group")

@fingolfin fingolfin force-pushed the mh/fix-galois-context-printing branch 2 times, most recently from b6bb365 to d9eaaec Compare October 2, 2023 16:43
- ensure 'Galois' is always uppercase
- ... but 'context' should be lowercase
- adjust some doctest filters that did not match anymore
  (they matched for "Group" where now we had "group")
@fingolfin fingolfin force-pushed the mh/fix-galois-context-printing branch from d9eaaec to 7d30ce9 Compare October 3, 2023 20:50
@fingolfin fingolfin requested a review from fieker October 3, 2023 20:50
@fingolfin fingolfin enabled auto-merge (squash) October 3, 2023 20:51
@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #2865 (7d30ce9) into master (aa9c04b) will increase coverage by 0.03%.
Report is 3 commits behind head on master.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2865      +/-   ##
==========================================
+ Coverage   80.49%   80.53%   +0.03%     
==========================================
  Files         456      456              
  Lines       65220    65194      -26     
==========================================
+ Hits        52501    52502       +1     
+ Misses      12719    12692      -27     
Files Coverage Δ
experimental/GaloisGrp/src/Solve.jl 70.86% <ø> (ø)
src/NumberTheory/GaloisGrp/GaloisGrp.jl 73.95% <50.00%> (ø)

... and 17 files with indirect coverage changes

Copy link
Contributor

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

be my guest

@fingolfin fingolfin merged commit 34196e6 into oscar-system:master Oct 4, 2023
10 of 15 checks passed
@fingolfin fingolfin deleted the mh/fix-galois-context-printing branch October 4, 2023 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants