Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes bug with loading vectorof Fields #3534

Merged
merged 2 commits into from Mar 20, 2024

Conversation

antonydellavecchia
Copy link
Collaborator

Adds fix for loading vectors of types that are serialized with ids.

@thofma
Copy link
Collaborator

thofma commented Mar 20, 2024

Merci!

Copy link
Collaborator

@thofma thofma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't know about the internals, but it fixes the issue.

Copy link

codecov bot commented Mar 20, 2024

Codecov Report

Merging #3534 (68db603) into master (693a3e4) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 50.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3534   +/-   ##
=======================================
  Coverage   82.10%   82.10%           
=======================================
  Files         567      567           
  Lines       76824    76826    +2     
=======================================
+ Hits        63077    63081    +4     
+ Misses      13747    13745    -2     
Files Coverage Δ
src/Serialization/containers.jl 95.41% <50.00%> (+0.80%) ⬆️

@thofma thofma merged commit 31228f5 into master Mar 20, 2024
27 checks passed
@thofma thofma deleted the 3531-serialization-loading-failing-for-vector branch March 20, 2024 16:03
@thofma thofma added the backport 1.0.x Should be backported to the release 1.0 branch label Mar 20, 2024
benlorenz pushed a commit that referenced this pull request Apr 9, 2024
@benlorenz benlorenz mentioned this pull request Apr 9, 2024
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Serialization (loading) failing for Vector
3 participants