Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes bug with loading vectorof Fields #3534

Merged
merged 2 commits into from
Mar 20, 2024
Merged

Fixes bug with loading vectorof Fields #3534

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
07c4c27
bug fixed
antonydellavecchia Mar 20, 2024
68db603
Update src/Serialization/containers.jl
antonydellavecchia Mar 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/Serialization/containers.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,9 @@ end
function load_object(s::DeserializerState, ::Type{<: Vector}, params::Type)
load_node(s) do v
if serialize_with_id(params)
loaded_v = params[load_ref(s, x) for x in v]
loaded_v::Vector{params} = load_array_node(s) do _
load_ref(s)
end
else
loaded_v = params[]
for (i, entry) in enumerate(v)
Expand All @@ -65,7 +67,9 @@ end
function load_object(s::DeserializerState, ::Type{<: Vector{params}}) where params
load_node(s) do v
if serialize_with_id(params)
loaded_v = params[load_ref(s, x) for x in v]
loaded_v = load_array_node(s) do _
antonydellavecchia marked this conversation as resolved.
Show resolved Hide resolved
load_ref(s)
end
else
loaded_v = params[]
for (i, entry) in enumerate(v)
Expand Down
27 changes: 18 additions & 9 deletions test/Serialization/Fields.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,15 +1,17 @@
@testset "Fields" begin
mktempdir() do path
Qx, x = QQ["x"]
K1, _ = number_field(x^2 + 5)
K2, _ = number_field([x^2 + 5, x^2 + 7])
K3, _ = number_field(x^2 + 7)
Kt, t = polynomial_ring(K1, cached = false)
L1, = number_field(t^2 + 2)
L2, = number_field([t^2 + 2, t^2 + 3])
Kt, t = polynomial_ring(K2, cached = false)
L3, = number_field(t^2 + 2)
L4, = number_field([t^2 + 2, t^2 + 3])

@testset "Field Embeddings" begin
Qx, x = QQ["x"]
K1, _ = number_field(x^2 + 5)
K2, _ = number_field([x^2 + 5, x^2 + 7])
Kt, t = polynomial_ring(K1, cached = false)
L1, = number_field(t^2 + 2)
L2, = number_field([t^2 + 2, t^2 + 3])
Kt, t = polynomial_ring(K2, cached = false)
L3, = number_field(t^2 + 2)
L4, = number_field([t^2 + 2, t^2 + 3])
for K in (K1, K2, L1, L2, L3, L4)
for E in complex_embeddings(K)
test_save_load_roundtrip(path, E) do loaded
Expand All @@ -24,5 +26,12 @@
end
end
end

@testset "Vector of Fields" begin
v = [K1, K3]
test_save_load_roundtrip(path, v) do loaded
@test loaded == v
end
end
end
end