-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to GAP.jl 0.11.1 resp. GAP 4.13.1 #3688
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #3688 +/- ##
==========================================
- Coverage 81.84% 81.52% -0.33%
==========================================
Files 580 580
Lines 79900 79864 -36
==========================================
- Hits 65398 65107 -291
- Misses 14502 14757 +255
|
@ThomasBreuer overall this looks pretty good; we could cherry-pick the (simple) fix in GAP that fixes the But in our discussion earlier today, it sounded as if you were aware of another issue with the new GAP / GAP.jl which is perhaps not reflected by the tests here (something about a book example) ? |
I meant this example:
where the idea was to show that |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
just FYI: the increased number of invalidations is reported to come from Oscar.jl/src/Rings/localization_interface.jl Lines 449 to 451 in 7d7bb9b
|
sigh two different crashes...
and also
|
Draft as there is a failing test I had to disable for now. We already have a fix for that in GAP, but I still need to apply it to the GAP_lib_jll . We might also just wait for GAP 4.13.1 which is due soon. But I would like to get full CI tests run now to make sure there aren't other regressions hiding.
Resolves #2341