Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to GAP.jl 0.11.1 resp. GAP 4.13.1 #3688

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Project.toml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ cohomCalg_jll = "5558cf25-a90e-53b0-b813-cadaa3ae7ade"
AbstractAlgebra = "0.41.3"
AlgebraicSolving = "0.4.15"
Distributed = "1.6"
GAP = "0.10.2"
GAP = "0.11.1"
Hecke = "0.32.0"
JSON = "^0.20, ^0.21"
JSON3 = "1.13.2"
Expand Down
2 changes: 1 addition & 1 deletion src/Groups/GAPGroups.jl
Original file line number Diff line number Diff line change
Expand Up @@ -1016,8 +1016,8 @@ julia> G = symmetric_group(5);
julia> low_index_subgroup_classes(G, 5)
3-element Vector{GAPGroupConjClass{PermGroup, PermGroup}}:
Conjugacy class of Sym(5) in G
Conjugacy class of Alt(5) in G
Conjugacy class of permutation group in G
Conjugacy class of Alt(5) in G
```
"""
function low_index_subgroup_classes(G::GAPGroup, n::Int)
Expand Down
8 changes: 4 additions & 4 deletions src/Groups/directproducts.jl
Original file line number Diff line number Diff line change
Expand Up @@ -33,14 +33,14 @@ julia> elements(G)
(4,5)
(2,3)
(2,3)(4,5)
(1,2)
(1,2)(4,5)
(1,2,3)
(1,2,3)(4,5)
(1,3,2)
(1,3,2)(4,5)
(1,3)
(1,3)(4,5)
(1,2,3)
(1,2,3)(4,5)
(1,2)
(1,2)(4,5)
```
"""
function direct_product(L::AbstractVector{<:GAPGroup}; morphisms::Bool=false)
Expand Down
4 changes: 2 additions & 2 deletions src/Groups/homomorphisms.jl
Original file line number Diff line number Diff line change
Expand Up @@ -515,10 +515,10 @@ Pc group of order 6
julia> iso = isomorphism(PermGroup, G)
Group homomorphism
from pc group of order 6
to permutation group of degree 6 and order 6
to permutation group of degree 3 and order 6

julia> permutation_group(G)
Permutation group of degree 6 and order 6
Permutation group of degree 3 and order 6

julia> codomain(iso) === ans
true
Expand Down
4 changes: 2 additions & 2 deletions test/book/cornerstones/groups/actions.jlcon
Original file line number Diff line number Diff line change
Expand Up @@ -60,10 +60,10 @@ Group homomorphism
julia> isomorphism(PermGroup, U)
Group homomorphism
from pc group of order 8
to permutation group of degree 8 and order 8
to permutation group of degree 4 and order 8

julia> permutation_group(U)
Permutation group of degree 8 and order 8
Permutation group of degree 4 and order 8

julia> for g in all_transitive_groups(degree => 3:9, !is_primitive)
h = image(optimal_perm_rep(g))[1]
Expand Down
Loading