Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make simplify_light return maps also for FreeModule case #3786

Merged
merged 2 commits into from
May 23, 2024

Conversation

aaruni96
Copy link
Member

Fixes #1745

@aaruni96 aaruni96 requested a review from fingolfin May 23, 2024 13:01
Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Now the return values are consistent.

@fieker
Copy link
Contributor

fieker commented May 23, 2024 via email

@afkafkafk13
Copy link
Collaborator

On Thu, May 23, 2024 at 07:35:18AM -0700, Anne Frühbis-Krüger wrote: @afkafkafk13 approved this pull request. Thank you. Now the return values are consistent.
Seperate question: why two maps? Wouldn't a single isomorphism (with the preimage installed) be the natural interface?

-- Reply to this email directly or view it on GitHub: #3786 (review) You are receiving this because you are subscribed to this thread. Message ID: @.***>

If you are interested in moving objects/subobjects back and forth, this is indeed the case. But if you need to give one map or the other as data to further computations, you need the map. Unfortunately, there is no reason to believe that the same direction would suffice for all applications which the user might have in mind.

@fingolfin fingolfin merged commit 41e2420 into oscar-system:master May 23, 2024
23 of 26 checks passed
@fingolfin fingolfin added the backport 1.0.x Should be backported to the release 1.0 branch label May 23, 2024
benlorenz pushed a commit that referenced this pull request May 24, 2024
@benlorenz benlorenz mentioned this pull request May 24, 2024
19 tasks
@benlorenz benlorenz removed the backport 1.0.x Should be backported to the release 1.0 branch label May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ext/ Tor outside sensible paramters crash
5 participants