small adjustions

[wdecker]

No description provided.

[rfourquet]

The Union can be put directly in lieu of U, and T is not used so can be removed:

Suggested change

	function hilbert_series(A::U) where U <: Union{MPolyRing{T}, MPolyQuo{T}} where T
	function hilbert_series(A::Union{MPolyRing, MPolyQuo})

[rfourquet]

Suggested change

	hilbert_series_reduced(A::U) where U <: Union{MPolyRing{T}, MPolyQuo{T}} where T
	hilbert_series_reduced(A::Union{MPolyRing, MPolyQuo})

[rfourquet]

The test error says:

MPolyQuo.normalize: Error During Test at /home/runner/work/Oscar.jl/Oscar.jl/test/Rings/MPolyQuo.jl:18
  Got exception outside of a @test
  UndefVarError: normalize not defined

[wdecker]

O.k., I replaced normalize by normalization and normalize_with_delta by normalization_with_delta without knowing that someone (I guess Dan) had already added tests. Sorry, I should have checked this. Also, the command is no longer in MPolyQuo.jl. but in mpoly_affine_algebras.jl. Should I now adjust the test file accordingly?

[rfourquet]

Should I now adjust the test file accordingly?

Yes this should be enough, the test occurences of normalize or normalize_with_delta seem to be only in the "test/Rings/MPolyQuo.jl".

[fingolfin]

@wdecker so I don't want to annoy you, and I am fine with merging this, but let me point out that what you do here is "not the Julia way". There, we should have two methods, one for each type. This allows Julia to produce better code, and is simply more in line with usual conventions there. So, in this example, it'd look like this (assuming I understand everything correctly here):

Suggested change

	function hilbert_series(A::Union{MPolyRing, MPolyQuo})
	if typeof(A) == FmpqMPolyRing
	Zt, t = ZZ["t"]
	return (one(parent(t)), (1-t)^(ngens(A)))
	end
	H = HilbertData(A.I)
	return hilbert_series(H,1)
	end
	function hilbert_series(A::FmpqMPolyRing)
	Zt, t = ZZ["t"]
	return (one(parent(t)), (1-t)^(ngens(A)))
	end
	function hilbert_series(A::Union{MPolyRing, MPolyQuo})
	H = HilbertData(A.I)
	return hilbert_series(H,1)
	end

This assumes you really wanted to just treat FmpqMPolyRing in a special way, but not e.g. FmpzMPolyRing or NmodMPolyRing or .... So perhaps you also meant this?

Suggested change

	function hilbert_series(A::Union{MPolyRing, MPolyQuo})
	if typeof(A) == FmpqMPolyRing
	Zt, t = ZZ["t"]
	return (one(parent(t)), (1-t)^(ngens(A)))
	end
	H = HilbertData(A.I)
	return hilbert_series(H,1)
	end
	function hilbert_series(A:: MPolyRing)
	Zt, t = ZZ["t"]
	return (one(parent(t)), (1-t)^(ngens(A)))
	end
	function hilbert_series(A::MPolyQuo)
	H = HilbertData(A.I)
	return hilbert_series(H,1)
	end

[wdecker]

Of course I meant MPolyRing rather than FmpqMPolyRing, this was a copy and paste mistake. Thanks for catching it. With regard to using Union{MPolyRing, MPolyQuo}: I will come back to this later later in the more general context of graded modules. For the time being, I would appreciate if someone could merge this so that I can continue working, building on new work by Delphine and Hans. I am greatful for all the comments which help me to get a better understanding of what I do, but waiting and waiting and waiting for a merge is really annoying.