Clean up for abelian closure #571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should wait for #570. |
thofma
force-pushed
the
th/qab
branch
3 times, most recently
from
86c124e
to
c86fd74
Compare
tthsqe12
suggested changes
Jul 21, 2021
|
Looks like you changed the printing of z_n to z(n). |
tthsqe12
reviewed
Jul 21, 2021
src/Rings/AbelianClosure.jl
Outdated
|
|
||
| _variable(K::QabField) = K.s | ||
|
|
||
| _variable(b::QabElem) = string(_variable(_Qab), "(", b.c, ")") |
There was a problem hiding this comment.
For expressification purposes, it would be best if this was
Expr(:call, Symbol(_variable(_Qab)), b.c)
Plain strings are the worst.
There was a problem hiding this comment.
Will do. Will also use the name macro.
tthsqe12
suggested changes
Jul 22, 2021
tthsqe12
reviewed
Jul 22, 2021
tthsqe12
approved these changes
Jul 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now with tests and documentation.