Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use new firebase admin sdk private key #81

Merged
merged 3 commits into from Jan 4, 2018

Conversation

rflorence
Copy link
Contributor

To maintain backwards compatibility, I kept the same auth parameter. If it's a filepath, treat it as an Admin SDK private key file. Otherwise, treat it as a database secret key.

Fixes #64, #80

Copy link
Collaborator

@vincentwoo vincentwoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! To merge, I would like to request that we change the argument from the filepath of the auth file to the string contents of the auth file for two reasons:

  1. This matches the passing scheme for the old secret.
  2. This works better in environments like Heroku that typically pass secrets via environment header. In general, there are many ways to pass secrets to applications and hopefully the library can accept all of them.

@rflorence
Copy link
Contributor Author

That sounds good to me. Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants