Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip Skype URLs #22

Merged
merged 4 commits into from
Nov 14, 2011
Merged

Skip Skype URLs #22

merged 4 commits into from
Nov 14, 2011

Conversation

avonderluft
Copy link
Contributor

No description provided.

@avonderluft
Copy link
Contributor Author

yes, sorry about. Adding the test.
In doing so I noticed that this test fails for me in rawler_spec.rb

can't convert Spec::Mocks::Mock into String
./spec/lib/../../lib/rawler/base.rb:22 :in new' ./spec/lib/../../lib/rawler/base.rb:22 :ininitialize'
./spec/lib/rawler_spec.rb:20 :in `new'
./spec/lib/rawler_spec.rb:20
20 Rawler.url = URI.escape(url)
21 output.sync = true
22 Rawler.output = Logger.new(output)

Just checking that you were aware of this.

@avonderluft
Copy link
Contributor Author

OK, test has been added. Thanks Oscar.

@oscardelben oscardelben merged commit b1494bc into oscardelben:master Nov 14, 2011
@oscardelben
Copy link
Owner

Pushed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants