-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
getCode() is missing a case for imageHtml #293
Comments
phptek
pushed a commit
to phptek/Embed
that referenced
this issue
Oct 18, 2018
|
Will do. Many thanks. |
@oscarotero Done. See #294 :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
In embed/embed/src/Adaptors//File.php the
getCode()
method doesn't work properly for remote images.As far as I can tell, there should be a clause for "imageHTML".
Adding the following clause to
getCode()
fixes the problem (Using v3.3.5 with PHP7.1)This method's
switch
block is also missing a default. It should decide what is a suitable default to pass onto API consmers. Default to a dummy1px x 1px
image in an<img>
element perhaps? Or throw an exception?The text was updated successfully, but these errors were encountered: