-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v3] YouTube oembed returning consent.youtube.com link #434
Comments
Re-opening as it’s now happening more widely for people (in the UK & EU anyway). Note that this only appears to be happening on v3 of the library, not sure if it’s patchable or if this will just be a “wontfix”. The problem is that when embedding a URL like
The library then tries to call the oembed endpoint with that URL as the source, instead of the original video URL:
A patch for this would ideally ensure that the oembed endpoint is called with the original URL. I’ve not investigated how much work that’s likely to be |
Update YouTube Oembed adapter to work with new consent page (fixes #434)
Ok, pull request merged and v3.4.14 published. |
Thanks @oscarotero! Unfortunately there’s one thing I didn’t take into consideration: when people use short Edit: #436 |
This isn’t really an issue with this library (at least, I’m 99% sure it isn’t) so I’ll close this straight away - I just wanted to post it here for visibility, in case someone else like me is searching for this problem and also wondering if they’re alone...
https://youtube.com/oembed
is sometimes returning an iframe as expected, and sometimes returning an anchor which links tohttps://consent.youtube.com
:I can’t recreate this locally, or even reliably on the live site, so it’s really difficult to try to debug what’s happening here. Given that the consent URL wants to redirect to the video, and not
https://youtube.com/oembed
, I can only assume that it is actually reaching the oembed API and that is returning the consent URL. Requesting the same embed code again later seems to work fine, so my best guess is that it depends which of YouTube’s edge servers responds.I’ve reported it to YouTube via the “Send Feedback” thing as that’s the only place I could find to report an issue. I have no idea if I should expect a response!
The text was updated successfully, but these errors were encountered: