Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(v3) Mixcloud OEmbed Provider #365

Merged
merged 2 commits into from
Jun 8, 2020
Merged

(v3) Mixcloud OEmbed Provider #365

merged 2 commits into from
Jun 8, 2020

Conversation

albertboada
Copy link

@albertboada albertboada commented Jun 6, 2020 •
edited
Loading

Resolves #361

Added a test as well:

Screen Shot 2020-06-06 at 11 39 40

(although other tests for other providers will make the whole test suite not pass because of unreachable urls and outdated apis)

@albertboada albertboada marked this pull request as draft June 6, 2020 17:19
@albertboada albertboada marked this pull request as ready for review June 6, 2020 17:28
@oscarotero oscarotero merged commit fdf2039 into oscarotero:v3.x Jun 8, 2020
@oscarotero
Copy link
Owner

thanks you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@albertboada @oscarotero