Heroku Installation

[ziyan-junaideen]

Hi @herestomwiththeweather

I have been trying to install a new instance of oscurrency. I did a new clone, bundle installed it and ran rake heroku:install.

1. providing a Heroku app
2. not providing Heroku app

Both failed giving the following errors. Noticing the fatal error happens arround git, I did git push "heroku". It did push as usual but at the end gave the following error: ! Push rejected, Could not communicate with vendor, please try again later.

Appreciate any help on this matter. Thanks

Ziyan

Option 1 - providing an existing application name

ziyan@ziyan-K55VD:~/Development/www/odesk/vrl/wsbptimebank$ rake heroku:install
DEPRECATION WARNING: You have Rails 2.3-style plugins in vendor/plugins! Support for these plugins will be removed in Rails 4.0. Move them out and bundle them in your Gemfile, or fold them in to your app as lib/myplugin/* and config/initializers/myplugin.rb. See the release notes for more on this: http://weblog.rubyonrails.org/2012/1/4/rails-3-2-0-rc2-has-been-released. (called from <top (required)> at /home/ziyan/Development/www/odesk/vrl/wsbptimebank/Rakefile:7)
[RailsAdmin] RailsAdmin initialization disabled by default. Pass SKIP_RAILS_ADMIN_INITIALIZER=false if you need it.
Enter your Heroku API key: XXXXXXXXXXXXXXXXXXXXXXX
Enter your Amazon Access Key ID: XXXXXXXXXXXXXXXXXXXXXXX
Enter your Amazon Secret Access Key: XXXXXXXXXXXXXXXXXXXXXXX
Enter the name of an existing Heroku app container (or leave blank to create a new one): wsbptimebank
Enter the name of the branch you wish to deploy (leave blank for master): 
done creating wsbptimebank.
Creating new S3 bucket... done.
Setting config vars... done.
Setting up mail server Enter your SMTP server address (or leave blank to use SendGrid): 
using SendGrid addon... done.
Setting up memcache... done.
Starting Git
Deploying to Heroku... git config "--list"  2>&1
user.name=Ziyan Junaideen
user.email=jdeen-solutions@outlook.com
push.default=simple
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=git@github.com:oscurrency/oscurrency.git
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
git remote "add" "--" "heroku" "git@heroku.com:wsbptimebank.git"  2>&1

git config "--list"  2>&1
user.name=Ziyan Junaideen
user.email=jdeen-solutions@outlook.com
push.default=simple
core.repositoryformatversion=0
core.filemode=true
core.bare=false
core.logallrefupdates=true
remote.origin.url=git@github.com:oscurrency/oscurrency.git
remote.origin.fetch=+refs/heads/*:refs/remotes/origin/*
branch.master.remote=origin
branch.master.merge=refs/heads/master
remote.heroku.url=git@heroku.com:wsbptimebank.git
remote.heroku.fetch=+refs/heads/*:refs/remotes/heroku/*
git push "heroku" ""  2>&1
fatal: remote part of refspec is not a valid name in 
rake aborted!
git push "heroku" ""  2>&1:fatal: remote part of refspec is not a valid name in 
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/gems/git-1.2.6/lib/git/lib.rb:718:in `command'
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/gems/git-1.2.6/lib/git/lib.rb:574:in `push'
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/gems/git-1.2.6/lib/git/base.rb:345:in `push'
/home/ziyan/Development/www/odesk/vrl/wsbptimebank/lib/tasks/heroku.rake:72:in `block (2 levels) in <top (required)>'
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/bin/ruby_executable_hooks:15:in `eval'
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => heroku:install
(See full trace by running task with --trace)

Options 2 - with no app

can't convert String into Integer
/home/ziyan/Development/www/odesk/vrl/wsbptimebank/lib/tasks/heroku.rake:21:in `[]'
/home/ziyan/Development/www/odesk/vrl/wsbptimebank/lib/tasks/heroku.rake:21:in `block (2 levels) in <top (required)>'
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/bin/ruby_executable_hooks:15:in `eval'
/home/ziyan/.rvm/gems/ruby-1.9.3-p484@wsbptimebank_project/bin/ruby_executable_hooks:15:in `<main>'
Tasks: TOP => heroku:install

[herestomwiththeweather]

in both cases, the problem is that the most recent change to the install script is attempting to treat an empty string return value from highline ask? method as if it were not true. since an empty string returns true, the problems occur. in the first case, branch is set to the empty string instead of the desired value which is master. in the second case, an empty string for the heroku application name causes the installation script to attempt to fetch an app with empty string instead of the desired behavior which is to create a new app.

[ziyan-junaideen]

Thanks Tom for this fix and the other fix that fixed the error when trying to login to a fresh installation.