Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make prettier config optional #30

Closed
ghost opened this issue Jan 1, 2020 · 2 comments
Closed

Make prettier config optional #30

ghost opened this issue Jan 1, 2020 · 2 comments
Labels

Comments

@ghost
Copy link

ghost commented Jan 1, 2020

Is there a way to opt out of the prettier config on klap init? Including it seems a bit too opinionated. What if a project is already using XO, or if it uses prettier from within ESLint, or it just prefers a different prettier config?

@osdevisnot
Copy link
Owner

Good point, I was hesitant to add prettier config in first place. Maybe we should just remove it and let author handle it accordingly.

Technically, we just need to remove @osdevisnot/prettier dependency and pkg.prettier field

osdevisnot added a commit that referenced this issue Jan 1, 2020
osdevisnot added a commit that referenced this issue Jan 1, 2020
@ghost ghost closed this as completed Jan 2, 2020
osdevisnot added a commit that referenced this issue Jan 2, 2020
@osdevisnot
Copy link
Owner

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant