-
-
Notifications
You must be signed in to change notification settings - Fork 356
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate buildSrc to build-logic, etc #1173
Conversation
- Remove deprecated `buildconfig` property - Disable Jetifier - Remove unnecessary jvmargs
prepare to use internal storage to comply with Google Play's policy
Migrate buildSrc to build-logic/convention
- Allow to use environment variables / Gradle properties to determine CMake and NDK version and build ABI - Use legacy packing for JNI libs
I don't like spliting 3 build to 12 build with Action matrix personally. We can build one abi(arm64-v8a) in local, but the CI should build all abi in one job. |
Make sense. I will make a way to do that. |
e826d2c
to
8892b4d
Compare
@Bambooin Done. |
Local
And this patch will break |
I didn't test the release build since it really takes time. You're right. It still makes sense to keep release packages splitted by API.
This is easy to fix, just change/add the file to grep. But I often thought it is too hacky to work. It seems that a better idea is to implement Reproducible Build: It is generally desirable that building the same source code with the same set of tools is reproducible, i.e. the output is always exactly the same. This makes it possible to verify that the build infrastructure for a binary distribution or embedded system has not been subverted. This can also make it easier to verify that a source or tool change does not make any difference to the resulting binaries. And I have attempted to do that in #1174. |
Found one serious issue: the latest |
Wierd. I will take time to investigate. |
8892b4d
to
4f1f878
Compare
4f1f878
to
82e82b2
Compare
@Bambooin Fixed. It caused by that I exclude an "unwanted" library which is actually depended by the app. |
This comment was marked as outdated.
This comment was marked as outdated.
210a6fd
to
521ea1f
Compare
521ea1f
to
5110c10
Compare
Fix blocking issue was fixed in the latest commit. You can append another commit with removing Then we can verify the gradle cache function is fine. |
@Bambooin Everything looks like OK. |
Yeah, I checked the cache in ci too. You can rebase your branch and merge to develop, then push directly to develop. |
@Bambooin Done. Thanks for review ~. |
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of pull request
This PR is still to improve build script quality.
Code of conduct
Style lint
make sytle-lint
Build pass
make debug
Manually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info