Enhance Theme Management #1214
Merged
Enhance Theme Management #1214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WhiredPlanck
force-pushed
the
theme-parse-and-data
branch
from
e7eddd7
to
b3ae278
Compare
nopdan
reviewed
Jan 29, 2024
nopdan
reviewed
Jan 29, 2024
nopdan
reviewed
Jan 29, 2024
WhiredPlanck
force-pushed
the
theme-parse-and-data
branch
3 times, most recently
from
02b4acb
to
0f2149f
Compare
|
No issue found for theme function. |
WhiredPlanck
force-pushed
the
theme-parse-and-data
branch
from
2472ab6
to
30bafe6
Compare
Co-authored-by: nopdan <xci@live.com>
Co-authored-by: nopdan <xci@live.com>
WhiredPlanck
force-pushed
the
theme-parse-and-data
branch
from
30bafe6
to
513e76a
Compare
|
@Bambooin Rebased for |
Also fix set input view background instead of its keyboard view background by mistake
Bambooin
approved these changes
Jan 31, 2024
fix: forgot reset some parameters when call `KeyboardSwitcher.newOrReset()` refactor: rename ThemeAndColor to Theme in AppPrefs Co-authored-by: nopdan <xci@live.com>
WhiredPlanck
force-pushed
the
theme-parse-and-data
branch
from
66c1cc1
to
a75746c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request
Issue tracker
Fixes will automatically close the related issues
Fixes # N/A
Feature
Describe features of pull request
Code of conduct
Style lint
make sytle-lintBuild pass
make debugManually test
Code Review
Daily build
Login and download artifact at https://github.com/osfans/trime/actions
Additional Info