Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: upgrade action to v4 #1228

Merged
merged 1 commit into from
Feb 6, 2024
Merged

ci: upgrade action to v4 #1228

merged 1 commit into from
Feb 6, 2024

Conversation

Bambooin
Copy link
Collaborator

@Bambooin Bambooin commented Feb 5, 2024

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #
Fixes #

Feature

Describe features of this pull request

This will dismiss the warning of deprecated Node.js 16

Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-java@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.

Code of conduct

Style lint

  • make sytle-lint

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

This will dismiss the warning of deprecated Node.js 16

> Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/setup-java@v3, actions/cache@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/.
@Bambooin Bambooin merged commit 1b4ea2c into osfans:develop Feb 6, 2024
3 checks passed
@Bambooin Bambooin deleted the node20 branch February 14, 2024 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant