Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix failed to load sound effects #1346

Merged
merged 1 commit into from Apr 26, 2024
Merged

Fix failed to load sound effects #1346

merged 1 commit into from Apr 26, 2024

Conversation

nopdan
Copy link
Contributor

@nopdan nopdan commented Apr 26, 2024 •
edited

再次弹出键盘丢失按键音效

Pull request

Issue tracker

Fixes will automatically close the related issues

Fixes #
Fixes #

Feature

Describe features of this pull request

Code of conduct

Code style

Build pass

  • make debug

Manually test

  • Done

Code Review

  1. No wildcards import
  2. Manual build and test pass
  3. GitHub Action CI pass
  4. At least one contributor review and approve
  5. Merged clean without conflicts
  6. PR will be merged by rebase upstream base

Daily build

Login and download artifact at https://github.com/osfans/trime/actions

Additional Info

@nopdan
fix: failed to load sound effects
275ca7d 
再次弹出键盘丢失按键音效
@WhiredPlanck WhiredPlanck merged commit 1197273 into osfans:develop Apr 26, 2024
4 checks passed
@nopdan nopdan deleted the sound branch April 26, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WhiredPlanck WhiredPlanck WhiredPlanck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nopdan @WhiredPlanck